Migrate Flax dataclass to the newest JAX pytree keypath API. #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_513588016
branch
5 times, most recently
from
100b8bf to
32877d3
Compare
cgarciae
reviewed
Mar 6, 2023
flax/core/frozen_dict.py
Outdated
| Returns: | ||
| A flattened version of this FrozenDict instance. | ||
| """ | ||
| return ((jax.tree_util.GetAttrKey('dict'), self._dict),), () |
There was a problem hiding this comment.
This is tricky. There should be a way to return no key at all since this is more of a proxy type.
There was a problem hiding this comment.
Alternatively, even though it would be slightly slower, we could do a single-level flattening e.g:
children = tuple(((jax.tree_util.GetAttrKey(key), value) for key, value in self._dict.items())
return children, ()
There was a problem hiding this comment.
Thank you Cristian! Your comment was addressed :)
copybara-service
bot
force-pushed
the
test_513588016
branch
from
32877d3 to
7c74517
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_513588016
branch
2 times, most recently
from
080d355 to
544cc60
Compare
Codecov Report
@@ Coverage Diff @@
## main #2921 +/- ##
==========================================
- Coverage 81.81% 81.76% -0.05%
==========================================
Files 55 55
Lines 5900 5906 +6
==========================================
+ Hits 4827 4829 +2
- Misses 1073 1077 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
copybara-service
bot
force-pushed
the
test_513588016
branch
2 times, most recently
from
5c65ba2 to
5ad0344
Compare
* `flax.struct.dataclass` already registered via `register_keypath`, and this one only changes it to latest API. * `flax.core.FrozenDict` was registered so that flattening a frozen dict should be the same as flattening the underlying dict. This makes its serialization backward-compatible. PiperOrigin-RevId: 515096454
copybara-service
bot
force-pushed
the
test_513588016
branch
from
5ad0344 to
c7fa10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Flax dataclass to the newest JAX pytree keypath API.
flax.struct.dataclassalready registered viaregister_keypath, and this one only changes it to latest API.flax.core.FrozenDictwas registered so that flattening a frozen dict should be the same as flattening the underlying dict. This makes its serialization backward-compatible.