Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the pjit guide to jax.jit #3016

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Apr 7, 2023

Fixes #2755:

  • Use jax.jit in place of pjit, and adjust explanations
  • Use jax.sharding instead of PartitionSpec wherever possible, in light of JAX's deprecation plan
  • Showcase how to use the API on existed layers (surprising that it wasn't showcased earlier...)

@IvyZX IvyZX requested a review from cgarciae April 7, 2023 01:30
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Merging #3016 (1cccadb) into main (efe3d57) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3016      +/-   ##
==========================================
+ Coverage   81.97%   82.12%   +0.14%     
==========================================
  Files          55       55              
  Lines        6002     6063      +61     
==========================================
+ Hits         4920     4979      +59     
- Misses       1082     1084       +2     

see 14 files with indirect coverage changes

@8bitmp3 8bitmp3 self-assigned this Jun 20, 2023
@copybara-service copybara-service bot merged commit bdb68ef into google:main Jun 20, 2023
IvyZX pushed a commit to IvyZX/flax that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve pjit guide
3 participants