Flax will default to returning regular dicts instead of FrozenDicts in the future. Some internal-only tests fail because they expect frozen params when creating TrainState. #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #3104 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 55 55
Lines 6037 6038 +1
=======================================
+ Hits 4947 4948 +1
Misses 1090 1090
|
copybara-service
bot
force-pushed
the
test_533567519
branch
from
82db69d
to
6f2b72f
Compare
copybara-service
bot
force-pushed
the
test_533567519
branch
4 times, most recently
from
9a98529
to
ded5156
Compare
copybara-service
bot
force-pushed
the
test_533567519
branch
from
ded5156
to
5946062
Compare
copybara-service bot
pushed a commit
to google-research/vmoe
that referenced
this pull request
Jun 1, 2023
…aking. PiperOrigin-RevId: 537092577
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
PiperOrigin-RevId: 537092577
copybara-service bot
pushed a commit
to google-research/vmoe
that referenced
this pull request
Jun 1, 2023
…aking. PiperOrigin-RevId: 537092577
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
PiperOrigin-RevId: 537092577
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
PiperOrigin-RevId: 537143879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flax will default to returning regular dicts instead of FrozenDicts in the future. Some internal-only tests fail because they expect frozen params when creating TrainState.