Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stackoverflow when loading pickled module #3286

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix stackoverflow when loading pickled module #3286

merged 1 commit into from
Aug 21, 2023

Conversation

cgarciae
Copy link
Collaborator

What does this PR do?

Fixes #3283. Raises AttributeError in _DescriptorWrapper.__getattr__ if wrapped attribute is not present to avoid stackoverlfow.

@levskaya
Copy link
Collaborator

I see this failure in tests: ValueError: Unsupported type: <class 'str'> - what is going on there?
another user reported seeing this odd error in another context yesterday - did something else break?

@copybara-service copybara-service bot merged commit 3a9df8e into main Aug 21, 2023
10 of 18 checks passed
@copybara-service copybara-service bot deleted the fix-cloudpickle branch August 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to cloudpickle nn.Module when property is set: "maximum recursion depth exceeded"
2 participants
@cgarciae @levskaya