Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated haiku guide with new JAX RNG api #3343

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Sep 15, 2023

updated haiku guide, after #3337 changed Flax to use the new Jax RNG api

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #3343 (089f237) into main (d9f83bf) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3343   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files          55       55           
  Lines        6363     6363           
=======================================
  Hits         5259     5259           
  Misses       1104     1104           
Files Changed Coverage Δ
flax/core/meta.py 95.40% <ø> (ø)
flax/core/scope.py 88.80% <ø> (ø)
flax/cursor.py 95.83% <ø> (ø)
flax/errors.py 86.48% <ø> (ø)
flax/linen/initializers.py 100.00% <ø> (ø)
flax/linen/module.py 92.02% <ø> (ø)
flax/linen/normalization.py 96.89% <ø> (ø)
flax/linen/summary.py 98.28% <ø> (ø)
flax/linen/transforms.py 94.14% <ø> (ø)
flax/linen/recurrent.py 97.30% <100.00%> (ø)

@chiamp chiamp requested a review from IvyZX September 15, 2023 22:05
Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@chiamp chiamp self-assigned this Sep 15, 2023
@copybara-service copybara-service bot merged commit 5d846a5 into google:main Sep 15, 2023
19 checks passed
@chiamp chiamp deleted the haiku_upgrade branch September 25, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants