Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix omnistaging issues #335

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Conversation

jheek
Copy link
Member

@jheek jheek commented Jun 24, 2020

These changes are required to be forward compatible with the upcoming omnistaging feature in Jax (jax-ml/jax#3370).

disable tracer check
@jheek jheek requested a review from levskaya June 24, 2020 12:03
@codecov-commenter
Copy link

Codecov Report

Merging #335 into master will decrease coverage by 0.28%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   79.32%   79.03%   -0.29%     
==========================================
  Files          34       34              
  Lines        2254     2247       -7     
==========================================
- Hits         1788     1776      -12     
- Misses        466      471       +5     
Impacted Files Coverage Δ
flax/jax_utils.py 62.37% <91.66%> (-2.05%) ⬇️
flax/nn/utils.py 93.33% <100.00%> (-4.67%) ⬇️
flax/nn/stochastic.py 71.05% <0.00%> (-2.64%) ⬇️
flax/nn/base.py 91.70% <0.00%> (-0.23%) ⬇️
flax/nn/normalization.py 82.71% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484cc11...ee20ca2. Read the comment docs.

Copy link
Collaborator

@levskaya levskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing these for the upcoming changes!

@copybara-service copybara-service bot merged commit daff403 into google:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants