Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fp8 ops use explicit broadcasting. #3374

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

levskaya
Copy link
Collaborator

Flax libraries use only explicit broadcasting and our unit tests enforce this, fix recent fp8 ops to follow this convention.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #3374 (2c2bd58) into main (242f84c) will increase coverage by 0.28%.
Report is 10 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3374      +/-   ##
==========================================
+ Coverage   83.22%   83.51%   +0.28%     
==========================================
  Files          55       56       +1     
  Lines        6571     6678     +107     
==========================================
+ Hits         5469     5577     +108     
+ Misses       1102     1101       -1     
Files Coverage Δ
flax/linen/__init__.py 100.00% <100.00%> (ø)
flax/linen/fp8_ops.py 100.00% <100.00%> (ø)
flax/linen/module.py 92.04% <100.00%> (ø)
flax/training/train_state.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@copybara-service copybara-service bot merged commit f39de8f into google:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants