added has_improved field to EarlyStopping
#3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiamp
changed the title
has_improved field to EarlyStopping
Codecov Report
@@ Coverage Diff @@
## main #3385 +/- ##
=======================================
Coverage 83.65% 83.66%
=======================================
Files 56 56
Lines 6799 6800 +1
=======================================
+ Hits 5688 5689 +1
Misses 1111 1111
|
|
Looks good but its a breaking change. Have you tested how much code is affected? |
chiamp
force-pushed
the
early_stopping
branch
from
21c41a5
to
b1d2cb9
Compare
cgarciae
approved these changes
Oct 17, 2023
chiamp
force-pushed
the
early_stopping
branch
from
b1d2cb9
to
b620117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2107.