Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed tabulate docstring #3452

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fixed tabulate docstring #3452

merged 1 commit into from
Nov 9, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Oct 30, 2023 •
edited
Loading

The tabulate docstring displays the formatted string improperly. This PR fixes the docstring formatting.

@chiamp chiamp self-assigned this Oct 30, 2023
@chiamp chiamp marked this pull request as draft October 30, 2023 20:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #3452 (7a35e17) into main (c008753) will not change coverage.
The diff coverage is n/a.

❗ Current head 7a35e17 differs from pull request most recent head e60eda3. Consider uploading reports for the commit e60eda3 to get more accurate results

@@           Coverage Diff           @@
##             main    #3452   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files          56       56           
  Lines        6802     6802           
=======================================
  Hits         5690     5690           
  Misses       1112     1112
Files Coverage Δ
flax/linen/summary.py 96.92% <ø> (ø)

@chiamp chiamp marked this pull request as ready for review October 30, 2023 20:42
@chiamp chiamp requested a review from cgarciae October 30, 2023 20:42
cgarciae
cgarciae approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chiamp !

@copybara-service copybara-service bot merged commit 50de4c4 into google:main Nov 9, 2023
19 checks passed
@chiamp chiamp deleted the tabulate branch November 9, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees

@chiamp chiamp

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiamp @codecov-commenter @cgarciae