Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] Improve docs #3478

Merged
merged 2 commits into from
Nov 10, 2023
Merged

[nnx] Improve docs #3478

merged 2 commits into from
Nov 10, 2023

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Nov 10, 2023

What does this PR do?

  • Improves why notebook.
  • updates NNX readme
  • Remove id and executionInfo from notebook's cell metadata.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Merging #3478 (0794889) into main (25bbace) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3478   +/-   ##
=======================================
  Coverage   52.16%   52.16%           
=======================================
  Files          91       91           
  Lines       10954    10954           
=======================================
  Hits         5714     5714           
  Misses       5240     5240           
Files Coverage Δ
flax/experimental/nnx/tests/test_rngs.py 100.00% <100.00%> (ø)

@copybara-service copybara-service bot merged commit 0b7db0d into main Nov 10, 2023
21 checks passed
@copybara-service copybara-service bot deleted the nnx-improve-readme branch November 10, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants