Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled ruff formatter #3482

Merged
merged 2 commits into from
Nov 15, 2023
Merged

disabled ruff formatter #3482

merged 2 commits into from
Nov 15, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Nov 13, 2023

Disabled ruff formatter for now because hanging indent can't be configured separately from regular indent, whereas the internal Google formatter has 4 space hanging indent and 2 space regular indent.

Original PR: #3455
Feature request for ruff: astral-sh/ruff#3907

@chiamp chiamp self-assigned this Nov 13, 2023
Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope we can re-enable it in the future

@copybara-service copybara-service bot merged commit 646da5b into google:main Nov 15, 2023
19 checks passed
@chiamp chiamp deleted the ruff branch November 15, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants