Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added enum support for tabulate #3485

Merged
merged 1 commit into from
Nov 15, 2023
Merged

added enum support for tabulate #3485

merged 1 commit into from
Nov 15, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Nov 14, 2023

Resolves #3484.
Added enum support for tabulate

@chiamp chiamp self-assigned this Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2f6e5ff) 52.10% compared to head (bbd74ea) 52.09%.
Report is 2 commits behind head on main.

Files Patch % Lines
flax/linen/summary.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3485      +/-   ##
==========================================
- Coverage   52.10%   52.09%   -0.02%     
==========================================
  Files          91       91              
  Lines       10968    10973       +5     
==========================================
+ Hits         5715     5716       +1     
- Misses       5253     5257       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgarciae
Copy link
Collaborator

cgarciae commented Nov 15, 2023

@chiamp wouldn't it be better to do this in _as_yaml_str?
This might add support for enums in other places as well.

@chiamp
Copy link
Collaborator Author

chiamp commented Nov 15, 2023

@cgarciae I moved it to _normalize_structure instead

Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chiamp !

@copybara-service copybara-service bot merged commit 79d925f into google:main Nov 15, 2023
19 checks passed
@chiamp chiamp deleted the enum branch November 15, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module.tabulate does not support Enum inputs
3 participants