Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] Add support for python container types #3486

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

cgarciae
Copy link
Collaborator

What does this PR do?

  • Adds support for list, tuple, and dict as Graph node types.
  • Renames ModuleDef as GraphDef
  • Refactors all the graph related code into graph_utils.py

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cgarciae cgarciae changed the title Add support for python container types [nnx] Add support for python container types Nov 15, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (091df13) 52.10% compared to head (eef8066) 52.96%.

Files Patch % Lines
flax/experimental/nnx/nnx/graph_utils.py 88.16% 40 Missing ⚠️
flax/experimental/nnx/nnx/proxy_caller.py 82.85% 6 Missing ⚠️
flax/experimental/nnx/nnx/helpers.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3486      +/-   ##
==========================================
+ Coverage   52.10%   52.96%   +0.86%     
==========================================
  Files          91       94       +3     
  Lines       10968    11199     +231     
==========================================
+ Hits         5715     5932     +217     
- Misses       5253     5267      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit 47f763d into main Nov 15, 2023
21 checks passed
@copybara-service copybara-service bot deleted the nnx-graph-utils branch November 15, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants