Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing mask argument to LayerNorm, RMSNorm, and GroupNorm. #3510

Merged
1 commit merged into from
Nov 30, 2023
Merged

Add missing mask argument to LayerNorm, RMSNorm, and GroupNorm. #3510

1 commit merged into from
Nov 30, 2023

Conversation

carlosgmartin
Copy link
Contributor

@chiamp
Copy link
Collaborator

chiamp commented Nov 28, 2023

Thanks for this! Can you also add tests using the mask for the normalization layers in the NormalizationTest class in tests/linen/linen_test.py?

@carlosgmartin
Copy link
Contributor Author

@chiamp Done.

@copybara-service copybara-service bot closed this pull request by merging all changes into google:main in c2c3fea Nov 30, 2023
@carlosgmartin carlosgmartin deleted the normalization_mask branch November 30, 2023 18:46
@chiamp chiamp mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosgmartin @chiamp