Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NNX/Linen consistency test for Embed layer #3513

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Add NNX/Linen consistency test for Embed layer #3513

merged 2 commits into from
Nov 29, 2023

Conversation

Micky774
Copy link
Collaborator

@Micky774 Micky774 commented Nov 28, 2023 •
edited
Loading

What does this PR do?

Add NNX/Linen consistency test for Embed layer

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@Micky774 Micky774 mentioned this pull request Nov 28, 2023
Closed
4 tasks
cgarciae
cgarciae approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome @Micky774 !

@copybara-service copybara-service bot merged commit e50b1b5 into google:main Nov 29, 2023
19 checks passed
@Micky774 Micky774 deleted the nnx_embed_api_test branch November 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Micky774 @cgarciae