[nnx] Fix graph_utils bug #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbobry
reviewed
Nov 30, 2023
| @@ -147,6 +147,9 @@ class _HashableMapping(tp.Mapping[HA, HB], tp.Hashable): | |||
| def __init__(self, mapping: tp.Mapping[HA, HB] | tp.Iterable[tuple[HA, HB]]): | |||
| self._mapping = dict(mapping) | |||
|
|
|||
| def __contains__(self, key: object) -> bool: | |||
There was a problem hiding this comment.
Is this unrelated? I think Mapping implements __contains__ in terms of other dunder methods.
There was a problem hiding this comment.
Yeah it does by calling getitem and catching a KeyError but that is super annoying for the debugger so I overwrote it.
superbobry
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
graph_utils,Variables were not being copied which is a problem in new Reference semantics.