Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced number of parameterizations for Conv NNX/Linen consistency test #3526

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Reduced number of parameterizations for Conv NNX/Linen consistency test #3526

merged 1 commit into from
Dec 5, 2023

Conversation

Micky774
Copy link
Collaborator

@Micky774 Micky774 commented Dec 1, 2023 •
edited
Loading

What does this PR do?

Reduced number of parameterizations for Conv NNX/Linen consistency test from 2304 to 8

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@Micky774
Copy link
Collaborator Author

Micky774 commented Dec 1, 2023

cc: @cgarciae

@copybara-service copybara-service bot merged commit 829e004 into google:main Dec 5, 2023
19 checks passed
@Micky774 Micky774 deleted the nnx_conv_test_trim branch December 6, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Micky774 @cgarciae