Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-factored features arg #3554

Merged
merged 1 commit into from
Dec 15, 2023
Merged

re-factored features arg #3554

merged 1 commit into from
Dec 15, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Dec 14, 2023

Standardized feature args to in_features and out_features, since NNX uses both in/out_features and features_in/out, while Linen only uses in/out_features.

@chiamp chiamp self-assigned this Dec 14, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2e51a4e) 56.17% compared to head (aa1703b) 56.17%.
Report is 4 commits behind head on main.

Files Patch % Lines
flax/experimental/nnx/nnx/nn/attention.py 83.33% 1 Missing ⚠️
flax/linen/attention.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3554   +/-   ##
=======================================
  Coverage   56.17%   56.17%           
=======================================
  Files         100      100           
  Lines       11890    11890           
=======================================
  Hits         6679     6679           
  Misses       5211     5211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiamp chiamp requested a review from cgarciae December 14, 2023 21:44
@cgarciae
Copy link
Collaborator

This is great, thanks!

@copybara-service copybara-service bot merged commit 82e1a27 into google:main Dec 15, 2023
16 checks passed
@chiamp chiamp deleted the nnx_features branch December 15, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants