Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed NNX decode and dynamic slicing #3576

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Dec 20, 2023

Added @giovannic's dynamic slicing fix to NNX.

Fixed NNX init_cache since it was initializing a cache with trailing dimensions (..., self.num_heads, self.out_features) instead of (..., self.num_heads, self.head_dim).

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (008c3cc) 56.32% compared to head (f17b4fe) 56.70%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3576      +/-   ##
==========================================
+ Coverage   56.32%   56.70%   +0.38%     
==========================================
  Files         100      100              
  Lines       11951    12006      +55     
==========================================
+ Hits         6731     6808      +77     
+ Misses       5220     5198      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgarciae cgarciae added Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. pull ready labels Jan 3, 2024
@copybara-service copybara-service bot merged commit 7cbc3c1 into google:main Jan 5, 2024
19 checks passed
@chiamp chiamp deleted the nnx_dynamic_slice branch January 9, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. pull ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants