[nnx] flaglib add get overloads #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
==========================================
+ Coverage 56.32% 56.33% +0.01%
==========================================
Files 100 100
Lines 11951 11959 +8
==========================================
+ Hits 6731 6737 +6
- Misses 5220 5222 +2 ☔ View full report in Codecov by Sentry. |
superbobry
reviewed
Dec 21, 2023
| ... | ||
|
|
||
| @tp.overload | ||
| def get(self, name: str, default: A) -> A: |
There was a problem hiding this comment.
I think the right return type is A | Any, because the value stored in the context is not guaranteed to be of type A.
superbobry
approved these changes
Dec 21, 2023
chiamp
reviewed
Dec 21, 2023
Comment on lines
+71
to
+74
| def get(self, name: str, default: A) -> A: | ||
| ... | ||
|
|
||
| def get(self, name: str, default: A = None) -> A | None: |
There was a problem hiding this comment.
do you need a separate overload if the method signatures are the same?
There was a problem hiding this comment.
The last non-@overloaded definition is not used by type checkers, so this LGTM.
chiamp
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds typing overloads for
flagslib.get.