Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] improve graph_utils._set_key_tuple #3592

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Dec 28, 2023

What does this PR do?

  • Checks if the position being updated is the same as the exiting one and returns instead of raising an error. This allows Module to use tuples in lifted transforms.
  • Includes some ruff formatting updates.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (85dfad2) 56.31% compared to head (3fcc013) 56.30%.

Files Patch % Lines
flax/experimental/nnx/nnx/graph_utils.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
- Coverage   56.31%   56.30%   -0.02%     
==========================================
  Files         100      100              
  Lines       11952    11955       +3     
==========================================
  Hits         6731     6731              
- Misses       5221     5224       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit 4fb5604 into main Jan 3, 2024
21 checks passed
@copybara-service copybara-service bot deleted the nnx-improve-tuple-set branch January 3, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants