[nnx] improve runtime flags #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-improve-first-from
branch
from
3c50061
to
602097b
Compare
cgarciae
force-pushed
the
nnx-improve-first-from
branch
from
602097b
to
6f4e428
Compare
cgarciae
force-pushed
the
nnx-improve-first-from
branch
from
6f4e428
to
5546627
Compare
chiamp
reviewed
Jan 9, 2024
| @@ -26,7 +26,7 @@ def test_basic(self): | |||
| out_features=6, | |||
| rngs=nnx.Rngs(0), | |||
| ) | |||
| y = module(jnp.ones((1, 7, 3))) | |||
| y = module(jnp.ones((1, 7, 3)), decode=False) | |||
There was a problem hiding this comment.
Might be worth adding another check/test to test instantiating MultiHeadAttention with decode=False as an init arg. It's already tested in the autoregressive test, but the main point of that test was to test jax.experimental.enable_x64
chiamp
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?