[nnx] cleanup CallableProxy #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3608 +/- ##
=======================================
Coverage 56.70% 56.70%
=======================================
Files 100 100
Lines 12006 12005 -1
=======================================
Hits 6808 6808
+ Misses 5198 5197 -1 ☔ View full report in Codecov by Sentry. |
chiamp
reviewed
Jan 9, 2024
chiamp
approved these changes
Jan 9, 2024
chiamp
requested changes
Jan 9, 2024
cgarciae
force-pushed
the
nnx-improve-callable-proxy
branch
from
2606a77
to
ec8af91
Compare
|
Thanks! Fixed. |
cgarciae
force-pushed
the
nnx-improve-callable-proxy
branch
from
ec8af91
to
b3c181d
Compare
chiamp
approved these changes
Jan 9, 2024
chiamp
reviewed
Jan 9, 2024
| @@ -330,10 +330,10 @@ def apply( | |||
| accessesor = DelayedAccessor() | |||
There was a problem hiding this comment.
still some typos here: accessesor -> accessor
flax/experimental/nnx/nnx/module.py
Outdated
Comment on lines
406
to
409
| accessesor: DelayedAccessor, *args, **kwargs | ||
| ) -> tuple[tp.Any, M]: | ||
| module = self.clone() | ||
| fn = accessesor(module) |
cgarciae
force-pushed
the
nnx-improve-callable-proxy
branch
from
b3c181d
to
44e96a2
Compare
chiamp
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CallableProxynow create aDelayedAccessorby default if no accessor is given.DelayedAccessorsat many callsitesCallableProxyis used.