add compact_name_scope v3 #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
compact_name_scope_v3
branch
3 times, most recently
from
6150a60 to
2980501
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3646 +/- ##
==========================================
- Coverage 56.25% 56.24% -0.01%
==========================================
Files 101 101
Lines 12184 12218 +34
==========================================
+ Hits 6854 6872 +18
- Misses 5330 5346 +16 ☔ View full report in Codecov by Sentry. |
chiamp
approved these changes
Jan 26, 2024
|
There's a merge conflict. Can you rebase and then run TGP? |
cgarciae
force-pushed
the
compact_name_scope_v3
branch
from
2980501 to
b183dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Take 3 due to internal pytype bug)
Adds the
nn.compact_name_scopedecorator that enables methods to act as compact name scopes as with regular Haiku methods, this makes porting Haiku code easier.