[nnx] add partial_init #3674
Merged
[nnx] add partial_init #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-partial-init
branch
from
c57dd91
to
684df20
Compare
cgarciae
force-pushed
the
nnx-partial-init
branch
from
684df20
to
fae4d1f
Compare
chiamp
reviewed
Feb 5, 2024
|
|
||
| graphdef: GraphDef[M] | ||
| state: State | ||
| state, graphdef = jax.jit(_partial_init_constructor)() |
There was a problem hiding this comment.
Should we add the option to pass in kwargs into jax.jit? e.g. if the user wanted to pass in shardings. Or can they do that at the top level if they jit partial_init?
There was a problem hiding this comment.
It would be tricky. Also NNX Variable applies sharding constraints if available so you should use that API instead.
chiamp
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
Module.partial_initclassmethod which makes it easier to initialize Module while reusing some preexistingState.