Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added kwargs to self.param and self.variable #3675

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Feb 1, 2024

added kwargs to self.param and self.variable

@chiamp chiamp self-assigned this Feb 1, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@marcvanzee marcvanzee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chiamp
Copy link
Collaborator Author

chiamp commented Feb 2, 2024

btw @marcvanzee, I was getting mypy errors until I removed **init_kwargs from the first overloaded function signature (e.g. here). Not sure if it's intended behavior with using **kwargs, but I filed a mypy bug here

@copybara-service copybara-service bot merged commit 182afc0 into google:main Feb 9, 2024
19 checks passed
@chiamp chiamp deleted the kwargs branch February 10, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants