Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] add demo.ipynb #3680

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[nnx] add demo.ipynb #3680

merged 1 commit into from
Feb 26, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Feb 6, 2024

What does this PR do?

Adds an NNX demo notebook.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9585e0) 56.14% compared to head (385e234) 56.13%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3680      +/-   ##
==========================================
- Coverage   56.14%   56.13%   -0.01%     
==========================================
  Files         102      102              
  Lines       12186    12220      +34     
==========================================
+ Hits         6842     6860      +18     
- Misses       5344     5360      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chiamp chiamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider executing the code blocks, so users can see the expected output of the print statements.

For reference, this is the rendered notebook that I see.

@copybara-service copybara-service bot merged commit 41ae533 into main Feb 26, 2024
21 checks passed
@copybara-service copybara-service bot deleted the nnx-demo-2 branch February 26, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants