Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nnx rmsnorm #3691

Merged
merged 1 commit into from
Feb 13, 2024
Merged

added nnx rmsnorm #3691

merged 1 commit into from
Feb 13, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Feb 13, 2024

added nnx rmsnorm

@chiamp chiamp self-assigned this Feb 13, 2024
@chiamp chiamp requested a review from cgarciae February 13, 2024 00:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c2c81ee) 57.71% compared to head (172078e) 58.99%.
Report is 2 commits behind head on main.

Files Patch % Lines
flax/experimental/nnx/nnx/nn/normalization.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3691      +/-   ##
==========================================
+ Coverage   57.71%   58.99%   +1.28%     
==========================================
  Files         103      103              
  Lines       12289    12368      +79     
==========================================
+ Hits         7092     7297     +205     
+ Misses       5197     5071     -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit c25f546 into google:main Feb 13, 2024
19 checks passed
@chiamp chiamp deleted the nnx_rms branch March 16, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants