Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleCell. #3697

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add SimpleCell. #3697

merged 1 commit into from
Feb 22, 2024

Conversation

carlosgmartin
Copy link
Contributor

Fixes #3681

Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlosgmartin for doing this! Looks great.

flax/linen/recurrent.py Outdated Show resolved Hide resolved
flax/linen/recurrent.py Outdated Show resolved Hide resolved
flax/linen/recurrent.py Outdated Show resolved Hide resolved
@carlosgmartin carlosgmartin reopened this Feb 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6181239) 59.02% compared to head (6be118c) 59.10%.
Report is 10 commits behind head on main.

Files Patch % Lines
flax/linen/recurrent.py 57.14% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3697      +/-   ##
==========================================
+ Coverage   59.02%   59.10%   +0.07%     
==========================================
  Files         103      103              
  Lines       12391    12454      +63     
==========================================
+ Hits         7314     7361      +47     
- Misses       5077     5093      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chiamp chiamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@copybara-service copybara-service bot merged commit b3ac6cb into google:main Feb 22, 2024
36 checks passed
@carlosgmartin carlosgmartin deleted the simple_rnn_cell branch February 22, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vanilla / Elman / simple RNN cell
4 participants