make make_rng default to 'params' #3699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3669.
The Flax team has decided to switch the default
make_rng
name to'params'
instead of'default'
.This would have the following effect (see the original proposal with
'default'
in #3668):self.make_rng(name='params')
callable without explicitly passing in a string name, in which it would default to the 'params' RNG stream{'params': random.key(0)})
to.init()
and.apply()
thatself.make_rng('other_rng_stream')
will use as the RNG seed if, for example,{'other_rng_stream': random.key(1)}
wasn't in the RNG mapping that was passed into.init()
or.apply()