Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctest and unbreak head #3753

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Mar 13, 2024

  • Add functionality to suppress certain absl.logging messages during doctest. This will not break or unbreak anything (because logs will not break doctest), but can help clean up the printouts.
  • Fix the Orbax upgrade guide to unbreak head.
  • Add default required arguments for ContextManager.__exit__ in tensorboard.py

@IvyZX IvyZX requested a review from chiamp March 13, 2024 01:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.43%. Comparing base (0c7d256) to head (3b23dc8).
Report is 1 commits behind head on main.

Files Patch % Lines
flax/metrics/tensorboard.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3753   +/-   ##
=======================================
  Coverage   58.43%   58.43%           
=======================================
  Files         102      102           
  Lines       12365    12365           
=======================================
  Hits         7225     7225           
  Misses       5140     5140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chiamp chiamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@copybara-service copybara-service bot merged commit ce8a3c7 into google:main Mar 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants