Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset_gate flag to MGUCell. #3760

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add reset_gate flag to MGUCell. #3760

merged 1 commit into from
Mar 19, 2024

Conversation

carlosgmartin
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 58.74%. Comparing base (c2af614) to head (b7b7df2).

Files Patch % Lines
flax/linen/recurrent.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3760      +/-   ##
==========================================
- Coverage   58.75%   58.74%   -0.02%     
==========================================
  Files         101      101              
  Lines       12413    12417       +4     
==========================================
+ Hits         7293     7294       +1     
- Misses       5120     5123       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgarciae
Copy link
Collaborator

Thanks @carlosgmartin !

flax/linen/recurrent.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@chiamp chiamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@copybara-service copybara-service bot merged commit 006da41 into google:main Mar 19, 2024
19 checks passed
@carlosgmartin carlosgmartin deleted the reset_gate_flag branch March 20, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants