Make TrainState's step possibly jax.Array. This makes replicate valid for type checking.
#3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_615941638
branch
2 times, most recently
from
f4898ce
to
1b8b15d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3763 +/- ##
==========================================
- Coverage 59.13% 59.12% -0.01%
==========================================
Files 101 101
Lines 12467 12468 +1
==========================================
Hits 7372 7372
- Misses 5095 5096 +1 ☔ View full report in Codecov by Sentry. |
copybara-service
bot
force-pushed
the
test_615941638
branch
from
1b8b15d
to
cbb5467
Compare
… valid for type checking. PiperOrigin-RevId: 615996178
copybara-service
bot
force-pushed
the
test_615941638
branch
from
cbb5467
to
718aa8c
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
718aa8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
TrainState'ssteppossibly jax.Array. This makesreplicatevalid for type checking.