fix tabulate on norm wrappers #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3772 +/- ##
==========================================
- Coverage 59.49% 59.48% -0.02%
==========================================
Files 101 101
Lines 12623 12627 +4
==========================================
+ Hits 7510 7511 +1
- Misses 5113 5116 +3 ☔ View full report in Codecov by Sentry. |
cgarciae
approved these changes
Mar 20, 2024
cgarciae
reviewed
Mar 20, 2024
| @@ -460,7 +460,7 @@ def _get_variables(): | |||
| call_depth = len(c.path) | |||
| inputs = _process_inputs(c.args, c.kwargs) | |||
|
|
|||
| if c.path in visited_paths: | |||
| if c.path in visited_paths or not hasattr(c.module, c.method): | |||
There was a problem hiding this comment.
Can you explain what is happening here? Why c doesn't have module and method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3735.
When using
map_variables,callscontains_CallInfoobjects where themethoddoes not exist in themodule, causing theAttributeErrorseen in #3735. This PR adds acheckto see if themethodexists in themodule.This is a partial fix meant to unblock the current issue. However we still need to address the underlying issue on why there seems to be
_CallInfoobjects with methods that do not exist in their corresponding modules being added to the_DynamicContext. See #3779.