Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended PyTreeNode to take dataclass kwargs #3785

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Mar 22, 2024

Resolves #3617.

Extended PyTreeNode to take dataclass kwargs, after #3645.

@chiamp chiamp self-assigned this Mar 22, 2024
@chiamp chiamp changed the title extended pytreenode to take dataclass kwargs extended PyTreeNode to take dataclass kwargs Mar 22, 2024
@chiamp chiamp requested a review from cgarciae March 22, 2024 23:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.49%. Comparing base (135b652) to head (9ccd27d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3785   +/-   ##
=======================================
  Coverage   59.49%   59.49%           
=======================================
  Files         101      101           
  Lines       12599    12599           
=======================================
  Hits         7496     7496           
  Misses       5103     5103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit b57e3aa into google:main Mar 26, 2024
19 checks passed
@chiamp chiamp deleted the pytreenode branch March 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[struct.dataclass] Consider adding optional kw_only arguments
3 participants