[nnx] TrainState uses struct #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-train-state-struct
branch
2 times, most recently
from
8f4df26 to
ee1a138
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3788 +/- ##
==========================================
+ Coverage 60.16% 60.29% +0.12%
==========================================
Files 101 101
Lines 12842 12846 +4
==========================================
+ Hits 7727 7745 +18
+ Misses 5115 5101 -14 ☔ View full report in Codecov by Sentry. |
cgarciae
force-pushed
the
nnx-train-state-struct
branch
2 times, most recently
from
8014194 to
7b70786
Compare
chiamp
approved these changes
Mar 28, 2024
cgarciae
force-pushed
the
nnx-train-state-struct
branch
2 times, most recently
from
e4e436e to
7c3704e
Compare
cgarciae
force-pushed
the
nnx-train-state-struct
branch
from
7c3704e to
51b97ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reimplements
nnx.TrainStateusingstruct.PyTreeNode.