[nnx] add GraphNode base class #3790
Merged
+331
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-graph-node-base
branch
4 times, most recently
from
5d9c822
to
e217b27
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3790 +/- ##
==========================================
+ Coverage 59.56% 59.62% +0.06%
==========================================
Files 101 101
Lines 12624 12655 +31
==========================================
+ Hits 7519 7546 +27
- Misses 5105 5109 +4 ☔ View full report in Codecov by Sentry. |
superbobry
approved these changes
Mar 27, 2024
| state = deepcopy(state) | ||
| return graphdef.merge(state) | ||
|
|
||
| def __hash__(self) -> int: |
There was a problem hiding this comment.
I'm more tented to remove this implementation of __hash__ and just have the base one.
| @@ -860,6 +887,101 @@ def _graph_update_static( | |||
| node_impl.set_key(node, name, value_updates) | |||
|
|
|||
|
|
|||
| @tp.overload | |||
There was a problem hiding this comment.
I personally would probably leave the overloading out. It is verbose and only marginally useful.
I understand that you are trying to preserve tuple cardinality, but I'm not sure how common such a mistake is to justify all this boilerplate.
cgarciae
force-pushed
the
nnx-graph-node-base
branch
4 times, most recently
from
34de63f
to
0db3362
Compare
cgarciae
force-pushed
the
nnx-graph-node-base
branch
from
0db3362
to
6948138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GraphNodeas a base class forModuleand other types that need a graph flatten/unflatten implementation according to Module's current definition.nnx.splitandnnx.updateto work with any graph node.nnx.mergeto match the spread signature returned by.split