Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] Fix nnx basics #3812

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[nnx] Fix nnx basics #3812

merged 1 commit into from
Apr 2, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Apr 2, 2024

What does this PR do?

Fixes nnx_basics guide to use static as the first return argument of split.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (5d9fd9f) to head (fbfc0d0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3812      +/-   ##
==========================================
+ Coverage   60.86%   60.87%   +0.01%     
==========================================
  Files         105      105              
  Lines       13045    13052       +7     
==========================================
+ Hits         7940     7946       +6     
- Misses       5105     5106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit e4bfdaf into main Apr 2, 2024
21 checks passed
@copybara-service copybara-service bot deleted the nnx-minor-fix-nnx-basics branch April 2, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants