New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nnx] add Dropout.rngs #3815

Merged

copybara-service merged 1 commit into main from nnx-dropout-optional-state

Apr 9, 2024

Collaborator

cgarciae commented Apr 2, 2024

What does this PR do?

Adds a .rngs: Rngs attribute to Dropout which can be provided at construction to avoid having to pass it at call time.
Removes the logic that set Rngs attributes to None after Module.__init__.
Adds test using the Dropout.rngs attribute.


          [nnx] add Dropout.rngs

1a1ca48

cgarciae changed the base branch from nnx-rng-tags to main

April 2, 2024 13:05

chiamp approved these changes

View reviewed changes

chiamp added the pull ready label

copybara-service bot merged commit 2718455 into main

4 checks passed

copybara-service bot deleted the nnx-dropout-optional-state branch

April 9, 2024 13:34

chiamp mentioned this pull request

updated nnx dropout #3841

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels