Fix cloudpickle sentinel cloning #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbobry
reviewed
Apr 4, 2024
| a = MyModule() | ||
|
|
||
| # Fails with ValueError: parent must be None, Module or Scope: | ||
| UnpickledMyModule = cloudpickle.loads(cloudpickle.dumps(MyModule)) |
There was a problem hiding this comment.
Why does cloudpickle pickle recreate the sentinel? Maybe you just need to define __reduce__ for it?
There was a problem hiding this comment.
Implemented it using __reduce__, thanks for the tip!
cgarciae
force-pushed
the
linen-cloudpickle-issue
branch
from
15c8594 to
d7c7c05
Compare
superbobry
approved these changes
Apr 5, 2024
cgarciae
force-pushed
the
linen-cloudpickle-issue
branch
from
d7c7c05 to
d00dfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses
isinstanceinstead ofisto check for_Sentinelinstances to avoid non uniqueness issues when usingcloudpickle(creates a new_Sentinelinstance for_unspecified_parent).