[linen] fix DenseGeneral init #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
linen-fix-dense-general-init
branch
from
ea16831
to
74e328e
Compare
chiamp
reviewed
Apr 10, 2024
pyproject.toml
Outdated
Comment on lines
149
to
150
| # DeprecationWarning: elementwise comparison failed; this will raise an error in the future. | ||
| "ignore:.*elementwise comparison failed; this will raise an error in the future.*:DeprecationWarning", |
There was a problem hiding this comment.
Where is this error originating from? Can it be fixed by jnp.broadcast_to or jnp.expand_dims? If this will throw an error in the future, we should probably try to fix it.
There was a problem hiding this comment.
I removed as it appears this is only happening locally
chiamp
approved these changes
Apr 10, 2024
cgarciae
force-pushed
the
linen-fix-dense-general-init
branch
from
74e328e
to
36ee794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the flattening / unflattening logic from
DenseGeneralinit wrappers. Original motivation for this was to better preserve the statistics for arrays with more than 2 feature dimension, however this can also be achieve via thein_axisandout_axisparameters of most initializers making this flattening process unnecesary.