[nnx] fix iter_nodes #3889
Merged
[nnx] fix iter_nodes #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3889 +/- ##
=======================================
Coverage 60.43% 60.43%
=======================================
Files 105 105
Lines 13263 13264 +1
=======================================
+ Hits 8015 8016 +1
Misses 5248 5248 ☔ View full report in Codecov by Sentry. |
superbobry
approved these changes
May 8, 2024
| @@ -1072,11 +1072,11 @@ def _iter_nodes( | |||
| if id(node) in visited: | |||
There was a problem hiding this comment.
Please add a docstring to iter_nodes explaining the iteration order, since that function is now public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
iter_nodesnow returns leaves first, this makes surgery less error prone.iter_nodesasnnx.iter_nodes