Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] fix mypy and pytype #3894

Merged
merged 2 commits into from
May 8, 2024
Merged

[nnx] fix mypy and pytype #3894

merged 2 commits into from
May 8, 2024

Conversation

cgarciae
Copy link
Collaborator

What does this PR do?

Enable mypy and pytype on CI and fixes existing errors.

@cgarciae cgarciae marked this pull request as draft April 30, 2024 12:17
@cgarciae cgarciae force-pushed the nnx-enable-mypy-pytype-ci branch 2 times, most recently from b07f761 to d256ff5 Compare April 30, 2024 15:33
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cgarciae cgarciae force-pushed the nnx-enable-mypy-pytype-ci branch 3 times, most recently from 263767c to 5077e56 Compare May 1, 2024 11:39
@cgarciae cgarciae force-pushed the nnx-enable-mypy-pytype-ci branch 4 times, most recently from 8f02346 to 15def59 Compare May 2, 2024 10:33
@cgarciae cgarciae marked this pull request as ready for review May 2, 2024 10:33
@cgarciae cgarciae force-pushed the nnx-enable-mypy-pytype-ci branch 11 times, most recently from bce897b to 47ad898 Compare May 3, 2024 16:30
@cgarciae cgarciae force-pushed the nnx-enable-mypy-pytype-ci branch from 47ad898 to 0459456 Compare May 3, 2024 18:12
@copybara-service copybara-service bot merged commit 2c833a9 into main May 8, 2024
21 checks passed
@copybara-service copybara-service bot deleted the nnx-enable-mypy-pytype-ci branch May 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants