New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nnx] cleanup graph #3915

Merged

copybara-service merged 1 commit into main from nnx-graph-comments

May 13, 2024

Collaborator

cgarciae commented May 9, 2024

What does this PR do?

Renames NodeDef.variables to leaves.
Changes to type of NodeDef.leaves to allow passing None indexes.
Adds non-VariableState leaves to NodeDef.leaves during flattening with a None index.
Adds more comments to the unflatten code and cleans up the logic a bit.

chiamp approved these changes

View reviewed changes

cgarciae force-pushed the nnx-graph-comments branch from ea0c2f1 to bffe7e0 Compare

May 13, 2024 11:54


          [nnx] cleanup graph

7b611e3

cgarciae force-pushed the nnx-graph-comments branch from bffe7e0 to 7b611e3 Compare

May 13, 2024 12:47

cgarciae added the pull ready label

copybara-service bot merged commit a2a6242 into main

21 checks passed

copybara-service bot deleted the nnx-graph-comments branch

May 13, 2024 13:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels