[nnx] make State generic #3964
Merged
[nnx] make State generic #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-generalize-state
branch
from
89ced50
to
8440db6
Compare
chiamp
reviewed
Jun 4, 2024
Comment on lines
+53
to
+55
| StateLeaf = tp.Union[VariableState[tp.Any], np.ndarray, jax.Array] | ||
| GraphState = State[Key, StateLeaf] | ||
| GraphFlatState = FlatState[StateLeaf] |
There was a problem hiding this comment.
for clarification, GraphState is a State, but StateLeaf, FlatState and GraphFlatState are not State's?
There was a problem hiding this comment.
Correct, State[K, V] is now a generic mapping, GraphState is a type alias for a specific type of State as returned by the graph APIs, and LeafState is a union describing the possible types of leaves you find in GraphState.
chiamp
approved these changes
Jun 4, 2024
cgarciae
force-pushed
the
nnx-generalize-state
branch
from
8440db6
to
3e8c672
Compare
cgarciae
force-pushed
the
nnx-generalize-state
branch
from
3e8c672
to
bfb7efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3955.
State[K, V].Stateannotations ingraphare redifined asGraphState = State[Key, StateLeaf].