Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated nnx.training #3975

Merged
merged 1 commit into from
Jun 11, 2024
Merged

updated nnx.training #3975

merged 1 commit into from
Jun 11, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Jun 6, 2024

This PR does the following:

  • added docstrings to nnx.training classes
  • added return types for method signatures

@chiamp chiamp self-assigned this Jun 6, 2024
@chiamp chiamp force-pushed the training branch 3 times, most recently from 3cd9b0c to d30b682 Compare June 6, 2024 23:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (abf36e5) to head (31adb00).
Report is 33 commits behind head on main.

Files Patch % Lines
flax/nnx/nnx/training/metrics.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #3975    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        102     106     +4     
  Lines      13208   13582   +374     
======================================
- Misses     13208   13582   +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiamp chiamp force-pushed the training branch 9 times, most recently from 2feaf9f to 83b0af7 Compare June 7, 2024 22:45
@chiamp chiamp requested a review from cgarciae June 7, 2024 23:19
@chiamp chiamp force-pushed the training branch 4 times, most recently from d1f9380 to 2f689da Compare June 11, 2024 16:07
@copybara-service copybara-service bot merged commit 998792a into google:main Jun 11, 2024
19 checks passed
@chiamp chiamp deleted the training branch June 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants