Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
params
ineval_step
eval_step
.mean()
to lossesThe documentation for batch norm is written in such a way, that directly copying from it results in an unpleasant bug where the
params
used ineval_step
refer to the initial parameters of the network. This causes metrics to show that the model is not generalising to the test set at all. This change hopefully saves someone else learning flax a similar scratch on the head.Checklist
checks if that's the case).