Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for batch norm docs #3982

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jkarwowski
Copy link
Contributor

Changes:

  • Fixed reference to params in eval_step
  • Fixed the docstring in eval_step
  • Added .mean() to losses

The documentation for batch norm is written in such a way, that directly copying from it results in an unpleasant bug where the params used in eval_step refer to the initial parameters of the network. This causes metrics to show that the model is not generalising to the test set at all. This change hopefully saves someone else learning flax a similar scratch on the head.

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).

Changes:
 - Fixed the docstring in `eval_step`
 - Added `.mean()` to losses
 - Fixed reference to `params` in `eval_step`
Copy link

google-cla bot commented Jun 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkarwowski for doing this!

@copybara-service copybara-service bot merged commit 5d6ca39 into google:main Jun 11, 2024
10 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants