Added nnx.graph.iter_children
#3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3991 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 106 106
Lines 13582 13657 +75
=====================================
- Misses 13582 13657 +75 ☔ View full report in Codecov by Sentry. |
cgarciae
reviewed
Jun 13, 2024
| linear Linear | ||
| submodule SubModule | ||
| """ | ||
| node_dict = graph.get_node_impl(self).node_dict(self) |
There was a problem hiding this comment.
Nice! This is more general.
cgarciae
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
nnx.graph.iter_children, which returns an iterator of only immediate childModule's (contrasted withnnx.graph.iter_modulesthat returns an iterator of ALL nestedModule's). Also updated docstring and tests for both methods.Maybe we can use more informative names like
iter_all_modulesanditer_child_modules?