Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nnx] fix grad #4007

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[nnx] fix grad #4007

merged 1 commit into from
Jun 20, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Jun 19, 2024 •
edited
Loading

What does this PR do?

  • Fixes a bug in nnx.grad where grad was not creating new references for non differentiable NNX objects found in *args.
  • Allows vmap's state_axes mapping to accept None axes.

@copybara-service copybara-service bot merged commit 54fe15f into main Jun 20, 2024
18 of 21 checks passed
@copybara-service copybara-service bot deleted the nnx-fix-grad branch June 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaka14732 ayaka14732 ayaka14732 approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgarciae @ayaka14732