Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to orbax documentation #4123

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Aug 9, 2024

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).

@cool-RR cool-RR marked this pull request as ready for review August 9, 2024 16:03
Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cool-RR!

@cool-RR
Copy link
Contributor Author

cool-RR commented Aug 16, 2024

@cgarciae I believe the test failure is not related to my change.

@cgarciae
Copy link
Collaborator

@cool-RR the issue is with pre-commit, please run:

pip install pre-commit
pre-commit run --all-files

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cool-RR
Copy link
Contributor Author

cool-RR commented Aug 17, 2024

@cgarciae Sorry, done now.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (31adb00) to head (885d8bc).
Report is 125 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4123    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        106     109     +3     
  Lines      13582   14266   +684     
======================================
- Misses     13582   14266   +684     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cool-RR
Copy link
Contributor Author

cool-RR commented Aug 23, 2024

@cgarciae Is this good for merging?

@copybara-service copybara-service bot merged commit d0942f9 into google:main Aug 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants